Skip to content

[Snyk] Fix for 1 vulnerabilities#5360

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-ae4523f8abcad76e7d64d506b7a6a015
Closed

[Snyk] Fix for 1 vulnerabilities#5360
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-ae4523f8abcad76e7d64d506b7a6a015

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented Jun 3, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/app-backend/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Improper Link Resolution Before File Access ('Link Following')
SNYK-JS-TARFS-10293725
  721  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Improper Link Resolution Before File Access ('Link Following')

Summary by Sourcery

Upgrade backend dependencies to remediate a tarfs 'Link Following' vulnerability.

Bug Fixes:

  • Fix high-severity Improper Link Resolution ('Link Following') vulnerability in tarfs.

Enhancements:

  • Pin @backstage/backend-common, @backstage/backend-plugin-api, and @backstage/config-loader to specific versions instead of workspace references.

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jun 3, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 3, 2025

Reviewer's Guide

This PR updates specific backend dependencies by replacing workspace references with fixed version numbers to remediate a high-severity file access vulnerability in tarfs.

Sequence Diagram: PR Handling for Snyk Dependency Update

sequenceDiagram
    participant SnykTool as "Snyk (Automated Tool)"
    participant SourceRepo as "Source Repository"
    actor Developer

    SnykTool->>SourceRepo: Creates PR with updated 'package.json' (fixes SNYK-JS-TARFS-10293725)
    SourceRepo-->>Developer: Notifies of PR

    Developer->>SourceRepo: Pulls changes

    opt Developer uses Yarn Zero-Installs
        Developer->>Developer: Runs 'yarn' to update '.yarn/cache'
    end

    opt yarn.lock update failed during PR creation
        Developer->>Developer: Manually updates 'yarn.lock'
    end

    Developer->>SourceRepo: Reviews changes
    Developer->>SourceRepo: Merges PR
Loading

File-Level Changes

Change Details Files
Pinned vulnerable Backstage backend dependencies to explicit versions
  • Replace @backstage/backend-common workspace:^ with 0.24.1
  • Replace @backstage/backend-plugin-api workspace:^ with 0.6.19
  • Replace @backstage/config-loader workspace:^ with 0.1.1
plugins/app-backend/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented Jun 3, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Comment on lines +48 to +51
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Resolution Issue: Replacing workspace:^ references with specific npm versions breaks the monorepo's internal dependency structure. This change would cause the app to use external package versions rather than the local workspace packages, potentially introducing version mismatches and development workflow issues.

For addressing the vulnerability in tar-fs, the fix should be applied within the workspace packages themselves while maintaining the workspace:^ syntax. This preserves the monorepo's integrity while still addressing the security concern.

Consider reverting these changes to keep workspace:^ and instead update the vulnerable dependency in the appropriate workspace package.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Jun 10, 2025
@github-actions github-actions Bot closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants